Skip to content

Conversation

@KunWuLuan
Copy link
Contributor

@KunWuLuan KunWuLuan commented Jan 6, 2026

… tests

This commit introduces a new environment variable KuberayTestArch that allows overriding the detected architecture in test environments. Previously, the system only relied on runtime.GOARCH to determine if ARM64 architecture was being used, but this change enables explicit architecture specification through the environment variable. This is particularly useful for testing scenarios where you want to force a specific architecture regardless of the actual runtime environment, improving test flexibility and consistency across different platforms.

Why are these changes needed?

Related issue number

to #4346

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

… tests

This commit introduces a new environment variable KuberayTestArch that allows
overriding the detected architecture in test environments. Previously, the
system only relied on runtime.GOARCH to determine if ARM64 architecture was
being used, but this change enables explicit architecture specification
through the environment variable. This is particularly useful for testing
scenarios where you want to force a specific architecture regardless of the
actual runtime environment, improving test flexibility and consistency
across different platforms.

Signed-off-by: KunWuLuan <[email protected]>
Copy link
Collaborator

@machichima machichima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@win5923 win5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think From v2.47, ray already support multi-arch, so we don't need to specified the -aarch64 anymore.
We can simply remove the runtime.GOARCH check.

image

Ref: ray-project/ray#31522

@Future-Outlier Future-Outlier changed the title Add KuberayTestArch environment variable for architecture override in… Support Multi-Arch Image in CI Jan 12, 2026
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
Copy link
Member

Hi, @KunWuLuan
since multi-arch is supported now, I just changed your title and your code,
feel free to revert it if I misunderstand anything, thank you!

@rueian rueian merged commit 6a22196 into ray-project:master Jan 12, 2026
29 checks passed
@github-project-automation github-project-automation bot moved this from can be merged to Done in @Future-Outlier's kuberay project Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants